Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 1473303003: adb_gdb allows ctrl-c for interrupting the debuggee (Closed)

Created:
5 years ago by watk
Modified:
5 years ago
Reviewers:
pasko
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

adb_gdb allows ctrl-c for interrupting the debuggee Previously adb_gdb started the gdbserver in a backgrounded bash subprocess. As a result, it was receiving SIGINTs when you used ctrl-c to to interrupt the debuggee in gdb. Now it's started backgrounded, but not in a subshell, which means it will be set to ignore SIGINT. (This behavior is under the "SIGNALS" heading in the bash man page.) It will still get killed by the EXIT trap, so it doesn't leak. BUG= Committed: https://crrev.com/458e26c62669faec41db97e60ae050dc60775e82 Cr-Commit-Position: refs/heads/master@{#361713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/adb_gdb View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
watk
Hey pasko@, PTAL
5 years ago (2015-11-25 01:30:44 UTC) #2
pasko
lgtm, thank you!
5 years ago (2015-11-25 13:21:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473303003/1
5 years ago (2015-11-25 18:15:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 19:00:21 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-25 19:01:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/458e26c62669faec41db97e60ae050dc60775e82
Cr-Commit-Position: refs/heads/master@{#361713}

Powered by Google App Engine
This is Rietveld 408576698