Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1473253002: Add offscreen mode to visualbench (Closed)

Created:
5 years ago by Chris Dalton
Modified:
5 years ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@visualbench_blit2
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add offscreen mode to visualbench Replaces "nvpr mode" with "offscreen mode" and a flag to enable/ disable nvpr. Assigns new config names to the various combinations of flags and begins printing them with the bench results in order to match nanobench. BUG=skia: Committed: https://skia.googlesource.com/skia/+/baf8fcbb1b7eb89d5190df804bbda33c2622eb88

Patch Set 1 #

Total comments: 1

Patch Set 2 : line wraps #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -16 lines) Patch
M tools/VisualBench/VisualBench.cpp View 1 2 4 chunks +10 lines, -2 lines 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/VisualBench/VisualFlags.h View 1 chunk +3 lines, -1 line 0 comments Download
M tools/VisualBench/VisualFlags.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M tools/VisualBench/VisualLightweightBenchModule.cpp View 1 4 chunks +23 lines, -6 lines 0 comments Download
M tools/VisualBench/WrappedBenchmark.h View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Chris Dalton
5 years ago (2015-11-24 14:01:09 UTC) #2
joshualitt
On 2015/11/24 14:01:09, Chris Dalton wrote: lgtm with nits
5 years ago (2015-11-24 14:43:43 UTC) #3
joshualitt
https://codereview.chromium.org/1473253002/diff/1/tools/VisualBench/VisualLightweightBenchModule.cpp File tools/VisualBench/VisualLightweightBenchModule.cpp (right): https://codereview.chromium.org/1473253002/diff/1/tools/VisualBench/VisualLightweightBenchModule.cpp#newcode49 tools/VisualBench/VisualLightweightBenchModule.cpp:49: SkDebugf("curr/maxrss\tloops\tmin\tmedian\tmean\tmax\tstddev\t%-*s\tconfig\tbench\n", FLAGS_samples, line wrap
5 years ago (2015-11-24 14:43:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473253002/20001
5 years ago (2015-11-24 16:56:29 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot/builds/4473)
5 years ago (2015-11-24 16:57:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473253002/40001
5 years ago (2015-11-24 17:07:17 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-24 17:20:30 UTC) #13
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/baf8fcbb1b7eb89d5190df804bbda33c2622eb88

Powered by Google App Engine
This is Rietveld 408576698