Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 1473243002: Clean up on URLSearchParams (Closed)

Created:
5 years ago by tyoshino (SeeGerritForStatus)
Modified:
5 years ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up on URLSearchParams - Use FRIEND_TEST_ALL_PREFIXES instead of pointing a TEST_F instance directly (it depends on the internals of gtest) - Simplify encodeFormData() code BUG=303152 R=mkwst Committed: https://crrev.com/1657900bb606890767fcd6c4ec20f77cae963edf Cr-Commit-Position: refs/heads/master@{#361614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M third_party/WebKit/Source/core/dom/URLSearchParams.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/URLSearchParams.cpp View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
tyoshino (SeeGerritForStatus)
5 years ago (2015-11-24 13:56:34 UTC) #3
Mike West
Yay! LGTM.
5 years ago (2015-11-24 17:16:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473243002/1
5 years ago (2015-11-24 17:17:20 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 18:35:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473243002/1
5 years ago (2015-11-25 09:31:56 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 09:36:55 UTC) #12
commit-bot: I haz the power
5 years ago (2015-11-25 09:37:47 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1657900bb606890767fcd6c4ec20f77cae963edf
Cr-Commit-Position: refs/heads/master@{#361614}

Powered by Google App Engine
This is Rietveld 408576698