Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1473233005: Revert of media: Add ProvisionFetcher mojo interface and implementation. (Closed)

Created:
5 years ago by dominickn
Modified:
5 years ago
CC:
Aaron Boodman, abarth-chromium, avayvod+watch_chromium.org, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mlamouri+watch-media_chromium.org, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Add ProvisionFetcher mojo interface and implementation. (patchset #6 id:100001 of https://codereview.chromium.org/1466633002/ ) Reason for revert: Breaks GN Android compilation with error: In file included from ../../content/browser/media/android/provision_fetcher_impl.cc:5: ../../content/browser/media/android/provision_fetcher_impl.h:13:10: fatal error: 'media/mojo/interfaces/provision_fetcher.mojom.h' file not found #include "media/mojo/interfaces/provision_fetcher.mojom.h" CC=lizeb,tedchoc,xhwang Original issue's description: > media: Add ProvisionFetcher mojo interface and implementation. > > Add a mojo servive to do provisioning for MediaDrm in a non-browser process. > > BUG=546107 > TEST=Tested running MediaDrmBridge in the GPU process and performing > provisioning in the Browser process through this mojo service. > > Committed: https://crrev.com/ee71a525527d3ae607bb4f0d7a747014d310ecae > Cr-Commit-Position: refs/heads/master@{#361521} TBR=rockot@chromium.org,jam@chromium.org,timav@chromium.org,xhwang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=546107 Committed: https://crrev.com/5b151bf5cae08c5bb81f68673226cd113c0a237b Cr-Commit-Position: refs/heads/master@{#361578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -295 lines) Patch
M content/browser/frame_host/frame_mojo_shell.cc View 3 chunks +0 lines, -16 lines 0 comments Download
D content/browser/media/android/provision_fetcher_impl.h View 1 chunk +0 lines, -53 lines 0 comments Download
D content/browser/media/android/provision_fetcher_impl.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M content/content_browser.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M media/mojo/interfaces/mojo_bindings.gyp View 1 chunk +0 lines, -23 lines 0 comments Download
D media/mojo/interfaces/provision_fetcher.mojom View 1 chunk +0 lines, -18 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M media/mojo/services/android_mojo_media_client.cc View 2 chunks +19 lines, -14 lines 0 comments Download
M media/mojo/services/default_mojo_media_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/mojo/services/mojo_media_client.h View 3 chunks +2 lines, -8 lines 0 comments Download
M media/mojo/services/mojo_media_client.cc View 2 chunks +4 lines, -6 lines 0 comments Download
D media/mojo/services/mojo_provision_fetcher.h View 1 chunk +0 lines, -42 lines 0 comments Download
D media/mojo/services/mojo_provision_fetcher.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M media/mojo/services/service_factory_impl.cc View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dominickn
Created Revert of media: Add ProvisionFetcher mojo interface and implementation.
5 years ago (2015-11-25 05:01:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473233005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473233005/1
5 years ago (2015-11-25 05:02:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-25 05:03:55 UTC) #3
commit-bot: I haz the power
5 years ago (2015-11-25 05:06:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b151bf5cae08c5bb81f68673226cd113c0a237b
Cr-Commit-Position: refs/heads/master@{#361578}

Powered by Google App Engine
This is Rietveld 408576698