Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: breakpad/breakpad.gyp

Issue 1473203002: [Linux] Turn off -mstackrealign for breakpad in ia32. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « breakpad/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'breakpad_sender.gypi', 7 'breakpad_sender.gypi',
8 'breakpad_handler.gypi', 8 'breakpad_handler.gypi',
9 ], 9 ],
10 'conditions': [ 10 'conditions': [
(...skipping 577 matching lines...) Expand 10 before | Expand all | Expand 10 after
588 ['OS!="android"', { 588 ['OS!="android"', {
589 'link_settings': { 589 'link_settings': {
590 'libraries': [ 590 'libraries': [
591 # In case of Android, '-ldl' is added in common.gypi, since it 591 # In case of Android, '-ldl' is added in common.gypi, since it
592 # is needed for stlport_static. For LD, the order of libraries 592 # is needed for stlport_static. For LD, the order of libraries
593 # is important, and thus we skip to add it here. 593 # is important, and thus we skip to add it here.
594 '-ldl', 594 '-ldl',
595 ], 595 ],
596 }, 596 },
597 }], 597 }],
598 ['clang==1 and target_arch=="ia32"', {
599 'cflags!': [
600 # Clang's -mstackrealign doesn't work well with
Lei Zhang 2015/11/24 15:03:20 nits (ditto in all the other comments): - Just 1
601 # linux_syscall_support.h hand written asm syscalls.
602 '-mstackrealign',
603 ],
604 }],
598 ], 605 ],
599 606
600 'include_dirs': [ 607 'include_dirs': [
601 'src', 608 'src',
602 'src/client', 609 'src/client',
603 'src/third_party/linux/include', 610 'src/third_party/linux/include',
604 '..', 611 '..',
605 '.', 612 '.',
606 ], 613 ],
607 }, 614 },
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
697 'sources': [ 704 'sources': [
698 'src/common/android/breakpad_getcontext_unittest.cc', 705 'src/common/android/breakpad_getcontext_unittest.cc',
699 ], 706 ],
700 'variables': { 707 'variables': {
701 'test_type': 'gtest', 708 'test_type': 'gtest',
702 'test_suite_name': '<(_target_name)', 709 'test_suite_name': '<(_target_name)',
703 'isolate_file': 'breakpad_unittests.isolate', 710 'isolate_file': 'breakpad_unittests.isolate',
704 }, 711 },
705 'includes': [ '../build/android/test_runner.gypi' ], 712 'includes': [ '../build/android/test_runner.gypi' ],
706 }], 713 }],
714 ['clang==1 and target_arch=="ia32"', {
715 'cflags!': [
716 # Clang's -mstackrealign doesn't work well with
717 # linux_syscall_support.h hand written asm syscalls.
718 '-mstackrealign',
719 ],
720 }],
707 ], 721 ],
708 }, 722 },
709 { 723 {
710 # GN version: //breakpad:linux_dumper_unittest_helper 724 # GN version: //breakpad:linux_dumper_unittest_helper
711 'target_name': 'linux_dumper_unittest_helper', 725 'target_name': 'linux_dumper_unittest_helper',
712 'type': 'executable', 726 'type': 'executable',
713 'dependencies': [ 727 'dependencies': [
714 'breakpad_processor_support', 728 'breakpad_processor_support',
715 ], 729 ],
716 'sources': [ 730 'sources': [
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
1000 'breakpad_unittests_apk.isolate', 1014 'breakpad_unittests_apk.isolate',
1001 ], 1015 ],
1002 }, 1016 },
1003 ] 1017 ]
1004 } 1018 }
1005 ], 1019 ],
1006 ], 1020 ],
1007 }], 1021 }],
1008 ], 1022 ],
1009 } 1023 }
OLDNEW
« no previous file with comments | « breakpad/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698