Implement Model-Driven-Views spec for Dart

tools/dom/dom.py

 #!/usr/bin/python
 
 # Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 # A script which makes it easy to execute common DOM-related tasks
 
 import os
 import subprocess
@@ skipping 80 matching lines @@
     '-o%s' % out_file
   ]
   if checked:
     args.append('--checked')
 
   call(args)
   return out_file
 
 def gen():
   os.chdir(os.path.join('tools', 'dom', 'scripts'))
-  return call([os.path.join(os.getcwd(), 'dartdomgenerator.py'),
+  result = call([os.path.join(os.getcwd(), 'dartdomgenerator.py'),
       '--rebuild', '--parallel', '--systems=htmldart2js,htmldartium'])
+  os.chdir(os.path.join('..', '..', '..'))

[blois, 2013/05/01 17:00:42]

Is this necessary? The script should reset the path after every command (see
init_dir())

[Jennifer Messerly, 2013/05/01 18:03:44]

Unless init_dir was a recent addition, yeah, this was a fix ;)

I was trying to run: "./tools/dom/dom.py gen test_drt <testName>" and it blew up
after "gen" because path was wrong... Hence this.

I can take a look and see why init_dir isn't working.

[Jennifer Messerly, 2013/05/01 18:11:46]

I figured it out.
Python __file__ is a relative path, so the result changes on the second call to
init_dir and it thinks my `os.path.dirname(os.path.realpath(__file__))` is:
"/mnt/code/dart/dart/tools/dom/scripts/tools/dom"

I think the abspath to dart_dir has to be saved before any chdir's happen. I'll
send you a fix for it.

+  return result
 
 def http_server():
   print('Browse tests at '
       '\033[94mhttp://localhost:5400/root_build/generated_tests/\033[0m')
   return call([
     utils.DartBinary(),
     os.path.join('tools', 'testing', 'dart', 'http_server.dart'),
     '--port=5400',
     '--crossOriginPort=5401',
     '--network=0.0.0.0',
@@ skipping 95 matching lines @@
       help();
       success = False
       break
     returncode = commands[command][0]()
     success = success and not bool(returncode)
 
   sys.exit(not success)
 
 if __name__ == '__main__':
   main()