components/page_load_metrics/browser/page_load_metrics_observer.cc - Issue 1473153002: PageLoadMetricsObservers observe individual page loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/page_load_metrics_observer.cc

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: destroy order Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/page_load_metrics/browser/page_load_metrics_observer.cc

diff --git a/components/page_load_metrics/browser/page_load_metrics_observer.cc b/components/page_load_metrics/browser/page_load_metrics_observer.cc

index 05b37303a1be7fa1162a09d31ccbe41b16cf60aa..436c67396e3d1907332e2c7811782796dd6a9189 100644

--- a/components/page_load_metrics/browser/page_load_metrics_observer.cc

+++ b/components/page_load_metrics/browser/page_load_metrics_observer.cc

@@ -9,9 +9,11 @@ namespace page_load_metrics {

PageLoadExtraInfo::PageLoadExtraInfo(

const base::TimeDelta& first_background_time,

const base::TimeDelta& first_foreground_time,

- bool started_in_foreground)

+ bool started_in_foreground,

+ bool has_commit)

: first_background_time(first_background_time),

first_foreground_time(first_foreground_time),

- started_in_foreground(started_in_foreground) {}

+ started_in_foreground(started_in_foreground),

+ has_commit(has_commit) {}

} // namespace page_load_metrics

« no previous file with comments | « components/page_load_metrics/browser/page_load_metrics_observer.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »