chrome/browser/page_load_metrics/page_load_metrics_initialize.h - Issue 1473153002: PageLoadMetricsObservers observe individual page loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.h

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Randy/Bryan review: needed to revert ~MWCO destructor for lifecycle reasons Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.cc ('k') | chrome/browser/page_load_metrics/page_load_metrics_initialize.cc » ('j') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.h

diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.h b/chrome/browser/page_load_metrics/page_load_metrics_initialize.h

index f9a78ca297b197389bfb29edcd1ae5e0dabd559b..e3aaa79bac1d6a59fa50ce926a1c0a87442d65d3 100644

--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.h

+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.h

@@ -20,13 +20,14 @@ namespace chrome {

void InitializePageLoadMetricsForWebContents(

content::WebContents* web_contents);

-class PageLoadMetricsEmbedderInterfaceImpl

+class PageLoadMetricsEmbedder

: public page_load_metrics::PageLoadMetricsEmbedderInterface {

public:

// PageLoadMetricsEmbedderInterface:

- ~PageLoadMetricsEmbedderInterfaceImpl() override;

+ ~PageLoadMetricsEmbedder() override;

rappor::RapporService* GetRapporService() override;

bool IsPrerendering(content::WebContents* web_contents) override;

+ void RegisterObservers(page_load_metrics::PageLoadTracker* tracker) override;

};

} // namespace chrome