Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Randy review: comment + simpler destructor Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
index 58eebca22a8fb8b653b330b4a782f9ca3ff8dbc6..1ae932b7854ce11e0e52aa505e7498e7415494e1 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
@@ -11,24 +11,19 @@
class FromGWSPageLoadMetricsObserver
: public page_load_metrics::PageLoadMetricsObserver {
public:
- explicit FromGWSPageLoadMetricsObserver(
- page_load_metrics::PageLoadMetricsObservable* metrics);
+ FromGWSPageLoadMetricsObserver();
// page_load_metrics::PageLoadMetricsObserver implementation:
void OnCommit(content::NavigationHandle* navigation_handle) override;
void OnComplete(
const page_load_metrics::PageLoadTiming& timing,
const page_load_metrics::PageLoadExtraInfo& extra_info) override;
- void OnPageLoadMetricsGoingAway() override;
protected:
// Called in tests.
void SetCommittedURLAndReferrer(const GURL& url,
const content::Referrer& referrer);
- private:
bool navigation_from_gws_;
Bryan McQuade 2015/12/03 22:10:36 can this be private?
Charlie Harrison 2015/12/03 22:30:25 Yep. Done.
- page_load_metrics::PageLoadMetricsObservable* const metrics_;
-
DISALLOW_COPY_AND_ASSIGN(FromGWSPageLoadMetricsObserver);
};

Powered by Google App Engine
This is Rietveld 408576698