Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1739)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase on #362343 Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
index 3de633280cea2921c1e34e12a0628ca9c2927f29..6d82459a81d7661eaa9979093953b48159f61095 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
@@ -12,33 +12,24 @@
#include "components/rappor/rappor_service.h"
#include "content/public/browser/web_contents.h"
-namespace {
-
-void RegisterPageLoadMetricsObservers(
- page_load_metrics::PageLoadMetricsObservable* metrics) {
- // Attach observers scoped to the web contents here.
-
- // This is a self-destruct class, and will delete itself when triggered by
- // OnPageLoadMetricsGoingAway.
- metrics->AddObserver(new FromGWSPageLoadMetricsObserver(metrics));
- metrics->AddObserver(
- new google_captcha_observer::GoogleCaptchaObserver(metrics));
-}
-
-} // namespace
-
namespace chrome {
void InitializePageLoadMetricsForWebContents(
content::WebContents* web_contents) {
- RegisterPageLoadMetricsObservers(
- page_load_metrics::MetricsWebContentsObserver::CreateForWebContents(
- web_contents,
- make_scoped_ptr(new PageLoadMetricsEmbedderInterfaceImpl())));
+ page_load_metrics::MetricsWebContentsObserver::CreateForWebContents(
+ web_contents,
+ make_scoped_ptr(new PageLoadMetricsEmbedderInterfaceImpl()));
}
PageLoadMetricsEmbedderInterfaceImpl::~PageLoadMetricsEmbedderInterfaceImpl() {}
+void PageLoadMetricsEmbedderInterfaceImpl::RegisterObservers(
+ page_load_metrics::PageLoadMetricsObservable* metrics) {
+ // These classes are owned by the metrics.
+ new FromGWSPageLoadMetricsObserver(metrics);
+ new google_captcha_observer::GoogleCaptchaObserver(metrics);
+}
+
rappor::RapporService*
PageLoadMetricsEmbedderInterfaceImpl::GetRapporService() {
// During the browser process shutdown path, calling this getter can

Powered by Google App Engine
This is Rietveld 408576698