chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc - Issue 1473153002: PageLoadMetricsObservers observe individual page loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase on #362343 Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h ('k') | chrome/browser/page_load_metrics/observers/google_captcha_observer.h » ('j') | components/page_load_metrics/browser/metrics_web_contents_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

index da8046aa770ac281e62ba05efefc51798d0168ef..ebf210b7e637231473ea6ec59fec65cce82ecdb3 100644

--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc

@@ -59,7 +59,7 @@ bool ShouldLogEvent(const base::TimeDelta& event,

FromGWSPageLoadMetricsObserver::FromGWSPageLoadMetricsObserver(

page_load_metrics::PageLoadMetricsObservable* metrics)

- : navigation_from_gws_(false), metrics_(metrics) {}

+ : PageLoadMetricsObserver(metrics), navigation_from_gws_(false) {}

void FromGWSPageLoadMetricsObserver::OnCommit(

content::NavigationHandle* navigation_handle) {

@@ -116,11 +116,6 @@ void FromGWSPageLoadMetricsObserver::OnComplete(

}

-void FromGWSPageLoadMetricsObserver::OnPageLoadMetricsGoingAway() {

- metrics_->RemoveObserver(this);

- delete this;

void FromGWSPageLoadMetricsObserver::SetCommittedURLAndReferrer(

const GURL& url,

const content::Referrer& referrer) {