Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2710)

Unified Diff: chrome/browser/page_load_metrics/observers/google_captcha_observer.cc

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Observe on creation Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
diff --git a/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc b/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
index 960cc3420b8d74406e195cc2c3306675e80f7221..78807abc9883f628fc9bda803e89b2783307e5a4 100644
--- a/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
+++ b/chrome/browser/page_load_metrics/observers/google_captcha_observer.cc
@@ -43,7 +43,7 @@ bool IsGoogleCaptcha(const GURL& url) {
GoogleCaptchaObserver::GoogleCaptchaObserver(
page_load_metrics::PageLoadMetricsObservable* metrics)
- : metrics_(metrics) {}
+ : PageLoadMetricsObserver(metrics) {}
void GoogleCaptchaObserver::OnCommit(
content::NavigationHandle* navigation_handle) {
@@ -57,9 +57,4 @@ void GoogleCaptchaObserver::OnRedirect(
RecordGoogleCaptchaEvent(GOOGLE_CAPTCHA_SOLVED);
}
-void GoogleCaptchaObserver::OnPageLoadMetricsGoingAway() {
- metrics_->RemoveObserver(this);
- delete this;
-}
-
} // namespace google_captcha_observer

Powered by Google App Engine
This is Rietveld 408576698