chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h - Issue 1473153002: PageLoadMetricsObservers observe individual page loads

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

Issue 1473153002: PageLoadMetricsObservers observe individual page loads (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Observe on creation Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('j') | chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

index 58eebca22a8fb8b653b330b4a782f9ca3ff8dbc6..d5d42d890eb332a14807bcdd58ac60e8cba4415b 100644

--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

+++ b/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h

@@ -18,18 +18,11 @@ class FromGWSPageLoadMetricsObserver

void OnComplete(

const page_load_metrics::PageLoadTiming& timing,

const page_load_metrics::PageLoadExtraInfo& extra_info) override;

- void OnPageLoadMetricsGoingAway() override;

protected:

// Called in tests.

void SetCommittedURLAndReferrer(const GURL& url,

const content::Referrer& referrer);

- private:

- bool navigation_from_gws_;

- page_load_metrics::PageLoadMetricsObservable* const metrics_;

- DISALLOW_COPY_AND_ASSIGN(FromGWSPageLoadMetricsObserver);

};

#endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_