Issue 1473143003: Merge to M47: Change |CCodec_ScanlineDecoder::m_Pitch| to FX_DWORD

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1473143003: Merge to M47: Change |CCodec_ScanlineDecoder::m_Pitch| to FX_DWORD (Closed)

Created:
5 years ago by Oliver Chang

Modified:
5 years ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@2526

Target Ref:
refs/heads/chromium/2526

Visibility:
Public.

More Reviews

Description

Merge to M47: Change |CCodec_ScanlineDecoder::m_Pitch| to FX_DWORD This matches the type of the corresponding |CFX_DIBSource::m_Pitch|, where integer overflow is checked for FX_DWORD. This change is propagated to many other places. Also, check for integer overflow in |CCodec_RLScanlineDecoder::Create| during the calculation of |m_Pitch| since it aligns to 4 bytes while overflow was was previously checked without this alignment. TBR=thestig@chromium.org BUG=555784 Original Review URL: https://codereview.chromium.org/1460033002 . (cherry picked from commit e7950df70a2fd658f466751b29483436cb31e829) Committed: https://pdfium.googlesource.com/pdfium/+/e668838baf79ff8bc0e13931feea5cd1877706eb

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -22 lines)			Patch
M	core/src/fxcodec/codec/codec_int.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec.cpp	View	5 chunks	+17 lines, -6 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_fax.cpp	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_flate.cpp	View	8 chunks	+17 lines, -9 lines	0 comments	Download
M	core/src/fxcodec/codec/fx_codec_jpeg.cpp	View	2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Oliver Chang

TBR. no real conflicts apart from tests (which were not included).

5 years ago (2015-11-24 20:23:08 UTC) #1

Oliver Chang

Committed patchset #1 (id:1) manually as e668838baf79ff8bc0e13931feea5cd1877706eb (presubmit successful).

5 years ago (2015-11-24 20:24:27 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages