Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 14731025: Add a fontConfig interface for android. (Closed)

Created:
7 years, 7 months ago by djsollen
Modified:
7 years, 7 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add a fontConfig interface for android. The contents of this CL are based on the SkFontHost_android.cpp found in the android repository. BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=9219

Patch Set 1 #

Patch Set 2 : passes tests still needs fallback support #

Patch Set 3 : add fallback support for testing #

Patch Set 4 : fix gyp #

Patch Set 5 : rebasing #

Patch Set 6 : remove android framework specific code #

Patch Set 7 : rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+751 lines, -135 lines) Patch
M gyp/ports.gyp View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M include/ports/SkTypeface_android.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
A src/ports/SkFontConfigInterface_android.cpp View 1 2 3 4 5 6 1 chunk +623 lines, -0 lines 0 comments Download
A + src/ports/SkFontConfigParser_android.h View 2 chunks +28 lines, -17 lines 0 comments Download
A + src/ports/SkFontConfigParser_android.cpp View 11 chunks +94 lines, -115 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
7 years, 7 months ago (2013-05-15 19:25:48 UTC) #1
djsollen
this should be cleaned up enough now that it is ready for review!
7 years, 7 months ago (2013-05-15 20:24:05 UTC) #2
reed1
lgtm
7 years, 7 months ago (2013-05-15 21:09:19 UTC) #3
djsollen
I'm going to hold off on submission until next week so that I'll be available ...
7 years, 7 months ago (2013-05-16 17:45:18 UTC) #4
djsollen
7 years, 7 months ago (2013-05-21 16:53:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #7 manually as r9219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698