Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: test_reflectable/test/reflected_type_test.dart

Issue 1473073009: Added `dynamicReflected..Type`, corrected type expressions. (Closed) Base URL: https://github.com/dart-lang/reflectable.git@master
Patch Set: Review response. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test_reflectable/test/new_instance_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test_reflectable/test/reflected_type_test.dart
diff --git a/test_reflectable/test/reflected_type_test.dart b/test_reflectable/test/reflected_type_test.dart
index 05c88a31e770a453c137c8accd7c4178189cd3a7..c4cbc73661a2b1b0f58416dbfdd53be078cd6685 100644
--- a/test_reflectable/test/reflected_type_test.dart
+++ b/test_reflectable/test/reflected_type_test.dart
@@ -39,8 +39,8 @@ class A {
null;
static int namedArguments(String x, List y, {String z: "4" + "2"}) => null;
- static List get staticGetset => ["42"];
- static void set staticGetset(List list) {}
+ static List<String> get staticGetset => ["42"];
+ static void set staticGetset(List<String> list) {}
}
final throwsNoCapability = throwsA(const isInstanceOf<NoSuchCapabilityError>());
@@ -143,7 +143,8 @@ main() {
expect(staticGetsetEqualsMirror.parameters.length, 1);
ParameterMirror staticGetsetEqualsParameter0 =
staticGetsetEqualsMirror.parameters[0];
- expect(staticGetsetEqualsParameter0.reflectedType, List);
+ expect(staticGetsetEqualsParameter0.reflectedType,
+ const TypeValue<List<String>>().type);
});
test('reflected return types, methods', () {
@@ -160,7 +161,8 @@ main() {
expect(oneArgumentMirror.reflectedReturnType, int);
expect(optionalArgumentsMirror.reflectedReturnType, int);
expect(namedArgumentsMirror.reflectedReturnType, int);
- expect(staticGetsetMirror.reflectedReturnType, List);
+ expect(staticGetsetMirror.reflectedReturnType,
+ const TypeValue<List<String>>().type);
expect(staticGetsetEqualsMirror.hasReflectedReturnType, false);
});
}
« no previous file with comments | « test_reflectable/test/new_instance_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698