Fix the crash problem of WebGL2 Query api.

Fix the crash problem of WebGL2 Query api.

It need to exception handling for null argument.

BUG=561217
Committed: https://crrev.com/9945a7390fca9a23c5ce365c5e4f39c2bf908cd6
Cr-Commit-Position: refs/heads/master@{#362879}

[cyzero.kim, 2015-11-25 05:13:06]

cyzero.kim@samsung.com changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[cyzero.kim, 2015-11-25 05:13:06]

Please review this one.

[Zhenyao Mo, 2015-11-25 18:16:34]

https://codereview.chromium.org/1473023007/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/1473023007/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:1597:
synthesizeGLError(GL_INVALID_OPERATION, "deleteQuery", "query object is null");
You should follow the same pattern from other delete functions, say,
WebGLRenderingContextBase::deleteTexture().  No GL error needed.

[cyzero.kim, 2015-11-26 13:21:29]

On 2015/11/25 18:16:34, Zhenyao Mo wrote:
>
https://codereview.chromium.org/1473023007/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
> (right):
> 
>
https://codereview.chromium.org/1473023007/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:1597:
> synthesizeGLError(GL_INVALID_OPERATION, "deleteQuery", "query object is
null");
> You should follow the same pattern from other delete functions, say,
> WebGLRenderingContextBase::deleteTexture().  No GL error needed.

Yes, It is a duplicate check.
I have removed it.
Please take another look.

[Zhenyao Mo, 2015-11-30 18:16:48]

https://codereview.chromium.org/1473023007/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
(right):

https://codereview.chromium.org/1473023007/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:1596: if
(!query)
You should also check for isContextLost() here.

[cyzero.kim, 2015-12-01 13:16:43]

On 2015/11/30 18:16:48, Zhenyao Mo wrote:
>
https://codereview.chromium.org/1473023007/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
> (right):
> 
>
https://codereview.chromium.org/1473023007/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp:1596:
if
> (!query)
> You should also check for isContextLost() here.

Right. I have added it.
Please take another look.

[Zhenyao Mo, 2015-12-01 18:36:08]

LGTM

[cyzero.kim, 2015-12-03 01:58:04]

The CQ bit was checked by cyzero.kim@samsung.com

[commit-bot: I haz the power, 2015-12-03 01:58:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1473023007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1473023007/40001

[commit-bot: I haz the power, 2015-12-03 03:05:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-03 03:06:09]

Description was changed from

==========
Fix the crash problem of WebGL2 Query api.

It need to exception handling for null argument.

BUG=561217
==========

to

==========
Fix the crash problem of WebGL2 Query api.

It need to exception handling for null argument.

BUG=561217

Committed: https://crrev.com/9945a7390fca9a23c5ce365c5e4f39c2bf908cd6
Cr-Commit-Position: refs/heads/master@{#362879}
==========

[commit-bot: I haz the power, 2015-12-03 03:06:09]

Patchset 3 (id:??) landed as
https://crrev.com/9945a7390fca9a23c5ce365c5e4f39c2bf908cd6
Cr-Commit-Position: refs/heads/master@{#362879}