Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 1473023004: Inline functions to speedup GetElement (Closed)

Created:
5 years, 1 month ago by Pan
Modified:
5 years ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Inline functions to speedup GetElement. BUG=None LOG=n Committed: https://crrev.com/bd5b19e4fea476d404e794202757e7411218a3ea Cr-Commit-Position: refs/heads/master@{#32354}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -36 lines) Patch
M src/lookup.h View 4 chunks +20 lines, -6 lines 0 comments Download
M src/lookup.cc View 4 chunks +3 lines, -19 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/objects-inl.h View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
Toon Verwaest
lgtm, thanks
5 years ago (2015-11-26 09:34:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473023004/80002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473023004/80002
5 years ago (2015-11-27 02:12:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/8209)
5 years ago (2015-11-27 02:15:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473023004/80002 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473023004/80002
5 years ago (2015-11-27 02:18:56 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:80002)
5 years ago (2015-11-27 02:51:39 UTC) #17
commit-bot: I haz the power
5 years ago (2015-11-27 02:52:25 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd5b19e4fea476d404e794202757e7411218a3ea
Cr-Commit-Position: refs/heads/master@{#32354}

Powered by Google App Engine
This is Rietveld 408576698