Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1473013003: PlzNavigate: use a SiteInstance to intialize the ServiceWorkerNavigationHandle (Closed)

Created:
5 years ago by clamy
Modified:
5 years ago
Reviewers:
nasko, davidben
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@downloads-fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: use a SiteInstance to intialize the ServiceWorkerNavigationHandle With this CL the StoragePartition used to get acces to the ServiceWorkerContextWrapper is accessed thanks to a SiteInstance instead of the navigation url. This fixes a bug in which WebViews navigating would initialize the ServiceWorkerNavigationHandle with the wrong ServiceWorkerContextWrapper, leading to the precreated ServiceWorkerProviderHost being stored in a wrong ServiceWorkerContextCore. When the renderer latter attempted to retrieve it, it would get killed due to the ServiceWorkerProviderHost not being found. This fixes ~90 WebView browser tests with PlzNavigate enabled. BUG=504347 Committed: https://crrev.com/7ba89802b549276c56d414fd8418fcf887e73342 Cr-Commit-Position: refs/heads/master@{#361673}

Patch Set 1 #

Patch Set 2 : Not depending on codereview.chromium.org/1467563002 anymore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -26 lines) Patch
M content/browser/frame_host/navigation_handle_impl.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_handle_impl.cc View 3 chunks +8 lines, -26 lines 0 comments Download
M content/browser/frame_host/navigation_request.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_request.cc View 3 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
clamy
@nasko: PTAL
5 years ago (2015-11-24 15:17:22 UTC) #3
nasko
Adding davidben@ as FYI, as he has been thinking about StoragePartitions and ServiceWorkers and this ...
5 years ago (2015-11-25 14:51:44 UTC) #5
nasko
LGTM
5 years ago (2015-11-25 14:51:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1473013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1473013003/20001
5 years ago (2015-11-25 15:29:58 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-11-25 16:30:15 UTC) #10
commit-bot: I haz the power
5 years ago (2015-11-25 16:31:21 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7ba89802b549276c56d414fd8418fcf887e73342
Cr-Commit-Position: refs/heads/master@{#361673}

Powered by Google App Engine
This is Rietveld 408576698