Chromium Code Reviews
DescriptionPlzNavigate: use a SiteInstance to intialize the ServiceWorkerNavigationHandle
With this CL the StoragePartition used to get acces to the
ServiceWorkerContextWrapper is accessed thanks to a SiteInstance instead of the
navigation url. This fixes a bug in which WebViews navigating would initialize
the ServiceWorkerNavigationHandle with the wrong ServiceWorkerContextWrapper,
leading to the precreated ServiceWorkerProviderHost being stored in a wrong
ServiceWorkerContextCore. When the renderer latter attempted to retrieve it, it
would get killed due to the ServiceWorkerProviderHost not being found. This
fixes ~90 WebView browser tests with PlzNavigate enabled.
BUG=504347
Committed: https://crrev.com/7ba89802b549276c56d414fd8418fcf887e73342
Cr-Commit-Position: refs/heads/master@{#361673}
Patch Set 1 #Patch Set 2 : Not depending on codereview.chromium.org/1467563002 anymore #
Messages
Total messages: 11 (5 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||