Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: content/public/test/render_view_test.cc

Issue 1472943004: Split up leak detector into two stages for better leak reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rephrase WebLeakDetector as two-phased Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/test/render_view_test.cc
diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc
index 9d546d8f7afbf8a1168351c9cbf096715aa529cb..0cb39a4b6617bb126d78529b8fd960df8f35f157 100644
--- a/content/public/test/render_view_test.cc
+++ b/content/public/test/render_view_test.cc
@@ -293,7 +293,7 @@ void RenderViewTest::TearDown() {
scoped_ptr<blink::WebLeakDetector> leak_detector =
make_scoped_ptr(blink::WebLeakDetector::create(this));
- leak_detector->collectGarbageAndGetDOMCounts(GetMainFrame());
+ leak_detector->prepareForLeakDetection(GetMainFrame());
view_ = NULL;
mock_process_.reset();
@@ -308,6 +308,8 @@ void RenderViewTest::TearDown() {
autorelease_pool_.reset(NULL);
#endif
+ leak_detector->collectGarbageAndReport();
+
blink_platform_impl_.Shutdown();
blink::shutdown();
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/WebLeakDetector.cpp » ('j') | third_party/WebKit/public/web/WebLeakDetector.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698