Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: content/shell/renderer/layout_test/leak_detector.cc

Issue 1472943004: Split up leak detector into two stages for better leak reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: call clearScriptRegexpContext() in prepareForLeakDetection() Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | third_party/WebKit/Source/web/WebLeakDetector.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/renderer/layout_test/leak_detector.cc
diff --git a/content/shell/renderer/layout_test/leak_detector.cc b/content/shell/renderer/layout_test/leak_detector.cc
index 3f935952a607aae89d365913793002ba9769379d..b1021f590d92806cd3409aa482378cfd7ea8835f 100644
--- a/content/shell/renderer/layout_test/leak_detector.cc
+++ b/content/shell/renderer/layout_test/leak_detector.cc
@@ -60,7 +60,8 @@ LeakDetector::~LeakDetector() {
}
void LeakDetector::TryLeakDetection(blink::WebLocalFrame* frame) {
- web_leak_detector_->collectGarbageAndGetDOMCounts(frame);
+ web_leak_detector_->prepareForLeakDetection(frame);
+ web_leak_detector_->collectGarbageAndReport();
}
void LeakDetector::onLeakDetectionComplete(
« no previous file with comments | « content/public/test/render_view_test.cc ('k') | third_party/WebKit/Source/web/WebLeakDetector.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698