Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Side by Side Diff: third_party/WebKit/public/web/WebLeakDetector.h

Issue 1472943004: Split up leak detector into two stages for better leak reporting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: call clearScriptRegexpContext() in prepareForLeakDetection() Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLeakDetector.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2014 Google Inc. All rights reserved. 2 * Copyright (C) 2014 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 unsigned numberOfLiveResources; 46 unsigned numberOfLiveResources;
47 unsigned numberOfLiveActiveDOMObjects; 47 unsigned numberOfLiveActiveDOMObjects;
48 unsigned numberOfLiveScriptPromises; 48 unsigned numberOfLiveScriptPromises;
49 unsigned numberOfLiveFrames; 49 unsigned numberOfLiveFrames;
50 unsigned numberOfLiveV8PerContextData; 50 unsigned numberOfLiveV8PerContextData;
51 }; 51 };
52 52
53 virtual void onLeakDetectionComplete(const Result&) = 0; 53 virtual void onLeakDetectionComplete(const Result&) = 0;
54 }; 54 };
55 55
56 // |WebLeakDetector| detects leaks of various Blink objects, counting
57 // the ones remaining after having reset Blink's global state and
58 // collected all garbage. See |WebLeakDetectorClient::Results|
59 // for the kinds of objects supported.
56 class WebLeakDetector { 60 class WebLeakDetector {
57 public: 61 public:
58 virtual ~WebLeakDetector() { } 62 virtual ~WebLeakDetector() { }
59 63
60 BLINK_EXPORT static WebLeakDetector* create(WebLeakDetectorClient*); 64 BLINK_EXPORT static WebLeakDetector* create(WebLeakDetectorClient*);
61 65
62 // Cleans up the DOM objects and counts them. |WebLeakDetectorClient::onLeak DetectionComplete()| is called when done. 66 // Leak detection is performed in two stages,
63 // This is supposed to be used for detecting DOM-object leaks. 67 // |prepareForLeakDetection()| and |collectGarbageAndReport()|.
64 virtual void collectGarbageAndGetDOMCounts(WebLocalFrame*) = 0; 68 //
69 // The first clearing out various global resources that a frame
70 // keeps, with the second clearing out all garbage in Blink's
71 // managed heaps before reporting leak counts.
72 //
73 // |WebLeakDetectorClient::onLeakDetectionComplete()| is called
74 // with the result of the (leaked) resource counting.
75 //
76 // By separating into two, the caller is able to inject any
77 // additional releasing of resources needed before the garbage
78 // collections go ahead.
79
80 // Perform initial stage of preparing for leak detection,
81 // releasing references to resources held globally.
82 virtual void prepareForLeakDetection(WebLocalFrame*) = 0;
83
84 // Garbage collect Blink's heaps and report leak counts.
85 // |WebLeakDetectorClient::onLeakDetectionComplete()| is called
86 // upon completion.
87 virtual void collectGarbageAndReport() = 0;
65 }; 88 };
66 89
67 } // namespace blink 90 } // namespace blink
68 91
69 #endif // WebLeakDetector_h 92 #endif // WebLeakDetector_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebLeakDetector.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698