media/base/android/media_codec_decoder_unittest.cc - Issue 1472943002: Refactor MediaCodecBridge to add support for NDK APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_codec_decoder_unittest.cc

Issue 1472943002: Refactor MediaCodecBridge to add support for NDK APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add media_codec_util.cc(h) Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/base/android/media_codec_bridge.cc ('K') | « media/base/android/media_codec_bridge_unittest.cc ('k') | media/base/android/media_codec_player_unittest.cc » ('j') | media/base/android/media_codec_util.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/android/media_codec_decoder_unittest.cc

diff --git a/media/base/android/media_codec_decoder_unittest.cc b/media/base/android/media_codec_decoder_unittest.cc

index 322407ba56f35156df3de96e9055760c9756f08c..dac3c1017bf3ffd32aa8a337006afbfdae6eaf6e 100644

--- a/media/base/android/media_codec_decoder_unittest.cc

+++ b/media/base/android/media_codec_decoder_unittest.cc

@@ -7,9 +7,10 @@

#include "base/thread_task_runner_handle.h"

#include "base/timer/timer.h"

#include "media/base/android/media_codec_audio_decoder.h"

-#include "media/base/android/media_codec_bridge.h"

+#include "media/base/android/media_codec_util.h"

#include "media/base/android/media_codec_video_decoder.h"

#include "media/base/android/media_statistics.h"

+#include "media/base/android/sdk_media_codec_bridge.h"

#include "media/base/android/test_data_factory.h"

#include "media/base/android/test_statistics.h"

#include "media/base/timestamp_constants.h"

@@ -21,7 +22,7 @@ namespace media {

// Helper macro to skip the test if MediaCodecBridge isn't available.

#define SKIP_TEST_IF_MEDIA_CODEC_BRIDGE_IS_NOT_AVAILABLE() \

do { \

- if (!MediaCodecBridge::IsAvailable()) { \

+ if (!IsMediaCodecAvailable()) { \

VLOG(0) << "Could not run test - not supported on device."; \

return; \

} \