src/codec/SkCodec_libgif.cpp - Issue 1472933002: Make SkAndroidCodec support ico

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/codec/SkCodec_libgif.cpp

Issue 1472933002: Make SkAndroidCodec support ico (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/codec/SkCodec_libgif.cpp

diff --git a/src/codec/SkCodec_libgif.cpp b/src/codec/SkCodec_libgif.cpp

index 8021af95a2e050f1b2df82985d9f467203e108b2..e6a40164f3549e591a569ba364a7eb78275c95d7 100644

--- a/src/codec/SkCodec_libgif.cpp

+++ b/src/codec/SkCodec_libgif.cpp

@@ -508,7 +508,7 @@ SkCodec::Result SkGifCodec::onStartScanlineDecode(const SkImageInfo& dstInfo,

void SkGifCodec::handleScanlineFrame(int count, int* rowsBeforeFrame, int* rowsInFrame) {

if (fFrameIsSubset) {

- const int currRow = this->INHERITED::nextScanline();

msarett 2015/11/24 22:43:35 This is a bug, as you've pointed out in the past.

+ const int currRow = this->currScanline();

// The number of rows that remain to be skipped before reaching rows that we

// actually must decode into.