Allows URL queries to be passed to contet handlers.

shell/application_manager/identity.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SHELL_APPLICATION_MANAGER_IDENTITY_H_
 #define SHELL_APPLICATION_MANAGER_IDENTITY_H_
 
 #include "url/gurl.h"
 
 namespace shell {
 
 /**
  * Represents the identity of an application. |url| is the url of the
  * application. |qualifier| is a string that allows to tie a specific instance
  * of an application to another. It is used by content handlers that need to be
- * run in the context of another application.
+ * run in the context of another application. If |with_query| is true, 2 urls
+ * with different query parameters will not have the same identity.

[ppi, 2015/11/24 10:47:21]

Can you describe the cases when we want to be "query sensitive" and when we
don't?

[qsr, 2015/11/24 12:24:32]

Changed identity to not care about query at all.

  */
 struct Identity {
-  Identity(const GURL& url, const std::string& qualifier);
-  explicit Identity(const GURL& url);
+  Identity(const GURL& url,
+           const std::string& qualifier,
+           bool with_query = false);

[ppi, 2015/11/24 10:47:21]

Passing "with_query" in a constructor results in weird semantics. If I create
two Identities, identity A("abc:abc?query", true) and B("abc:abc", false), then
from perspective of B, B is equal to A, but not the other way round.

being query sensitive ideally would be a parameter of some comparison function,
not of an "Identity".

[ppi, 2015/11/24 10:47:21]

"bool query_sensitive" would probably be clearer - "with_query" suggests that
the flag is somehow about presence of the query parameters in the url.

[qsr, 2015/11/24 12:24:32]

Acknowledged.

[qsr, 2015/11/24 12:24:32]

Acknowledged.

+  explicit Identity(const GURL& url, bool with_query = false);
   bool operator<(const Identity& other) const;
 
   const GURL url;
   const std::string qualifier;
 };
 
 }  // namespace shell
 
 #endif  // SHELL_APPLICATION_MANAGER_IDENTITY_H_