Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Unified Diff: chromeos/network/network_connection_handler.cc

Issue 14729017: Add NetworkHandler to own network handlers in src/chromeos/network (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase + Add NetworkConnectionHandler to NetworkHandler Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/network_connection_handler.cc
diff --git a/chromeos/network/network_connection_handler.cc b/chromeos/network/network_connection_handler.cc
index 0d98a45817973dbf8954932084676f84c5847dc2..bd6dc18e7014096c92e895c4147207093c79930c 100644
--- a/chromeos/network/network_connection_handler.cc
+++ b/chromeos/network/network_connection_handler.cc
@@ -107,8 +107,6 @@ bool CertificateIsConfigured(NetworkUIData* ui_data) {
} // namespace
-static NetworkConnectionHandler* g_connection_handler_instance = NULL;
-
const char NetworkConnectionHandler::kErrorNotFound[] = "not-found";
const char NetworkConnectionHandler::kErrorConnected[] = "connected";
const char NetworkConnectionHandler::kErrorConnecting[] = "connecting";
@@ -123,30 +121,19 @@ const char NetworkConnectionHandler::kErrorConfigurationRequired[] =
"configuration-required";
const char NetworkConnectionHandler::kErrorShillError[] = "shill-error";
-// static
-void NetworkConnectionHandler::Initialize() {
- CHECK(!g_connection_handler_instance);
- g_connection_handler_instance = new NetworkConnectionHandler;
-}
-
-// static
-void NetworkConnectionHandler::Shutdown() {
- CHECK(g_connection_handler_instance);
- delete g_connection_handler_instance;
- g_connection_handler_instance = NULL;
+NetworkConnectionHandler::NetworkConnectionHandler()
+ : network_state_handler_(NULL),
+ network_configuration_handler_(NULL) {
}
-// static
-NetworkConnectionHandler* NetworkConnectionHandler::Get() {
- CHECK(g_connection_handler_instance)
- << "NetworkConnectionHandler::Get() called before Initialize()";
- return g_connection_handler_instance;
-}
-
-NetworkConnectionHandler::NetworkConnectionHandler() {
+NetworkConnectionHandler::~NetworkConnectionHandler() {
}
-NetworkConnectionHandler::~NetworkConnectionHandler() {
+void NetworkConnectionHandler::Init(
+ NetworkStateHandler* network_state_handler,
+ NetworkConfigurationHandler* network_configuration_handler) {
+ network_state_handler_ = network_state_handler;
+ network_configuration_handler_ = network_configuration_handler;
}
void NetworkConnectionHandler::ConnectToNetwork(
@@ -154,7 +141,7 @@ void NetworkConnectionHandler::ConnectToNetwork(
const base::Closure& success_callback,
const network_handler::ErrorCallback& error_callback) {
const NetworkState* network =
- NetworkStateHandler::Get()->GetNetworkState(service_path);
+ network_state_handler_->GetNetworkState(service_path);
if (!network) {
InvokeErrorCallback(service_path, error_callback, kErrorNotFound);
return;
@@ -182,7 +169,7 @@ void NetworkConnectionHandler::ConnectToNetwork(
if (!network->connectable() && NetworkMayNeedCredentials(network)) {
// Request additional properties to check.
- NetworkConfigurationHandler::Get()->GetProperties(
+ network_configuration_handler_->GetProperties(
network->path(),
base::Bind(&NetworkConnectionHandler::VerifyConfiguredAndConnect,
AsWeakPtr(), success_callback, error_callback),
@@ -199,7 +186,7 @@ void NetworkConnectionHandler::DisconnectNetwork(
const base::Closure& success_callback,
const network_handler::ErrorCallback& error_callback) {
const NetworkState* network =
- NetworkStateHandler::Get()->GetNetworkState(service_path);
+ network_state_handler_->GetNetworkState(service_path);
if (!network) {
InvokeErrorCallback(service_path, error_callback, kErrorNotFound);
return;
@@ -217,7 +204,7 @@ void NetworkConnectionHandler::CallShillConnect(
const network_handler::ErrorCallback& error_callback) {
// TODO(stevenjb): Remove SetConnectingNetwork and use this class to maintain
// the connecting network(s) once NetworkLibrary path is eliminated.
- NetworkStateHandler::Get()->SetConnectingNetwork(service_path);
+ network_state_handler_->SetConnectingNetwork(service_path);
network_event_log::AddEntry(kLogModule, "Connect Request", service_path);
DBusThreadManager::Get()->GetShillServiceClient()->Connect(
dbus::ObjectPath(service_path),
@@ -246,7 +233,7 @@ void NetworkConnectionHandler::VerifyConfiguredAndConnect(
const std::string& service_path,
const base::DictionaryValue& properties) {
const NetworkState* network =
- NetworkStateHandler::Get()->GetNetworkState(service_path);
+ network_state_handler_->GetNetworkState(service_path);
if (!network) {
InvokeErrorCallback(service_path, error_callback, kErrorNotFound);
return;

Powered by Google App Engine
This is Rietveld 408576698