chromium_tests: require explicit compile targets (except for Android)

scripts/slave/recipe_modules/chromium_tests/api.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import ast
 import contextlib
 import copy
 import itertools
 import json
 
@@ skipping 450 matching lines @@
 
     if bot_config.get('archive_build') and not self.m.tryserver.is_tryserver:
       self.m.chromium.archive_build(
           'archive_build',
           bot_config['gs_bucket'],
           bot_config.get('gs_acl'),
           mode='dev'
       )
 
   def run_mb_and_compile(self, compile_targets, isolated_targets, name_suffix):
+    # TODO(phajdan.jr): Also enable error on android.
+    if not compile_targets and self.m.chromium.c.TARGET_PLATFORM != 'android':
+      # TODO(phajdan.jr): Mark as infra failure (make python module support it).
+      self.m.python.failing_step(
+          'compile', 'Please add explicit compile targets for the build')
+
     if self.m.chromium.c.project_generator.tool == 'mb':
       # We don't use the mastername and buildername passed in, because
       # those may be the values of the continuous builder the trybot may
       # be configured to match; we need to use the actual mastername
       # and buildername we're running on, because it may be configured
       # with different MB settings.
       real_mastername = self.m.properties['mastername']
       real_buildername = self.m.properties['buildername']
       self.m.chromium.run_mb(real_mastername, real_buildername,
                              isolated_targets=isolated_targets,
@@ skipping 333 matching lines @@
       result_text = 'MB is enabled for this builder at this revision.'
       log_name = 'Builder MB-ready'
       self.m.step.active_result.presentation.logs[log_name] = [result_text]
       return False
     except (self.m.step.StepFailure, KeyError):
       result_text = 'MB is not enabled for this builder at this revision.'
       log_name = 'Builder NOT MB-ready'
       self.m.step.active_result.presentation.logs[log_name] = [result_text]
       self.m.step.active_result.presentation.status = self.m.step.WARNING
       return True