Issue 1472883003: Add some more discussion of asynchrony.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1472883003: Add some more discussion of asynchrony. (Closed)

Created:
5 years, 1 month ago by nweiz

Modified:
5 years ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Add some more discussion of asynchrony. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/f639c2c6e8d50d2b754a5fec6c1f83f4a02ea8e8

Patch Set 1 #

Total comments: 1

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	json_reporter.md	View		2 chunks	+7 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kevmoo

LGTM other than oops https://codereview.chromium.org/1472883003/diff/1/json_reporter.md File json_reporter.md (right): https://codereview.chromium.org/1472883003/diff/1/json_reporter.md#newcode1 json_reporter.md:1: xxJSON Reporter Protocol oops?

5 years ago (2015-11-24 05:05:11 UTC) #2

nweiz

5 years ago (2015-11-24 05:08:49 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f639c2c6e8d50d2b754a5fec6c1f83f4a02ea8e8 (presubmit successful).

Expand Messages | Collapse Messages