Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1472873003: Revert of views/mus: Fix showing menu in chrome in mus. (Closed)

Created:
5 years, 1 month ago by beaudoin
Modified:
5 years ago
Reviewers:
jam, sadrul, sky
CC:
chromium-reviews, tfarina, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of views/mus: Fix showing menu in chrome in mus. (patchset #2 id:20001 of https://codereview.chromium.org/1460003004/ ) Reason for revert: Suspected in build failure. see crbug.com/560461 Original issue's description: > views/mus: Fix showing menu in chrome in mus. > > For menus in chrome-in-mus, we attempt to create a Widget hosted in a native > window. For desktop builds, this means we attempt to host in a HWND or an > X11 window created by DesktopNativeWidgetAura. But for mus, we want to use > NativeWidgetMus. To do this, use the native-widget factory first if it's > available. > > BUG=none > > Committed: https://crrev.com/2914df72a605451828a05e108c35fe9a1d72c971 > Cr-Commit-Position: refs/heads/master@{#361151} TBR=sky@chromium.org,jam@chromium.org,sadrul@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/25c81fcd8c425e404fc2fe2bbc840c3971867c81 Cr-Commit-Position: refs/heads/master@{#361163}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -13 lines) Patch
M base/threading/thread_restrictions.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/chrome_views_delegate.cc View 2 chunks +1 line, -5 lines 0 comments Download
M ui/views/mus/window_manager_connection.cc View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
beaudoin
Created Revert of views/mus: Fix showing menu in chrome in mus.
5 years, 1 month ago (2015-11-23 20:07:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472873003/1
5 years, 1 month ago (2015-11-23 20:09:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 20:15:52 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/25c81fcd8c425e404fc2fe2bbc840c3971867c81 Cr-Commit-Position: refs/heads/master@{#361163}
5 years, 1 month ago (2015-11-23 20:17:10 UTC) #4
msw
5 years ago (2015-11-24 03:28:43 UTC) #5
Message was sent while issue was closed.
On 2015/11/23 20:17:10, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/25c81fcd8c425e404fc2fe2bbc840c3971867c81
> Cr-Commit-Position: refs/heads/master@{#361163}

This revert likely caused the app_tests step to fail on FYI bot "Chromium Mojo
Android":
https://build.chromium.org/p/chromium.mojo/builders/Chromium%20Mojo%20Android...

I filed http://crbug.com/560626: Chromium Mojo Android app_tests step failing

Powered by Google App Engine
This is Rietveld 408576698