Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(814)

Issue 1472863003: Revert of Add SkPngChunkReader. (Closed)

Created:
5 years, 1 month ago by scroggo
Modified:
5 years, 1 month ago
Reviewers:
msarett, djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add SkPngChunkReader. (patchset #9 id:160001 of https://codereview.chromium.org/1040453002/ ) Reason for revert: Busted Chromium builds: ../../third_party/skia/src/ports/SkImageDecoder_empty.cpp:63:17: error: no type named 'Peeker' in 'SkImageDecoder' SkImageDecoder::Peeker* SkImageDecoder::setPeeker(Peeker*) { ~~~~~~~~~~~~~~~~^ ../../third_party/skia/src/ports/SkImageDecoder_empty.cpp:63:51: error: unknown type name 'Peeker' SkImageDecoder::Peeker* SkImageDecoder::setPeeker(Peeker*) { Original issue's description: > Add SkPngChunkReader. > > This class allows a client of SkCodec to read chunks in the data > stream that are not recognized by libpng. This is used by Android > to specify ninepatch data. > > Taken from SkImageDecoder::Peeker. Modify the name of the class > and its method to be more specific to their use. Make > SkImageDecoder::Peeker a subclass of the new class, to help stage > the change in Android. > > Add a test to verify that it works. > > BUG=skia:4574 > BUG=skia:3257 > > Committed: https://skia.googlesource.com/skia/+/3389e00136188800b98ca69488c0418c374fd78b TBR=djsollen@google.com,reed@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4574 Committed: https://skia.googlesource.com/skia/+/93c69fff535075e86596a2b224f52f454b060be3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -328 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M include/codec/SkCodec.h View 2 chunks +2 lines, -9 lines 0 comments Download
M include/core/SkImageDecoder.h View 4 chunks +17 lines, -17 lines 0 comments Download
D include/core/SkPngChunkReader.h View 1 chunk +0 lines, -45 lines 0 comments Download
M src/codec/SkCodec.cpp View 4 chunks +13 lines, -22 lines 0 comments Download
M src/codec/SkCodec_libpng.h View 4 chunks +10 lines, -12 lines 0 comments Download
M src/codec/SkCodec_libpng.cpp View 9 chunks +27 lines, -58 lines 0 comments Download
M src/images/SkImageDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/images/SkImageDecoder_libpng.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M tests/CodexTest.cpp View 2 chunks +0 lines, -160 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scroggo
Created Revert of Add SkPngChunkReader.
5 years, 1 month ago (2015-11-23 15:56:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472863003/1
5 years, 1 month ago (2015-11-23 15:56:34 UTC) #2
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 15:56:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/93c69fff535075e86596a2b224f52f454b060be3

Powered by Google App Engine
This is Rietveld 408576698