Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1472853005: Expose the SVG path normalizer in SVGPathParser.h (Closed)

Created:
5 years, 1 month ago by fs
Modified:
5 years, 1 month ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Expose the SVG path normalizer in SVGPathParser.h Rename the internal NormalizingConsumer to SVGPathNormalizer and move the class declaration to SVGPathParser.h. This will allow simplifying the "path processor" (SVGPathParser) a bit in later CLs. Also modify the normalizer so that it normalizes into a new PathSegmentData, to make it more "stackable" and reusable. BUG=467592 Committed: https://crrev.com/7b2566560022cdec110c2ec09068723ccc969a16 Cr-Commit-Position: refs/heads/master@{#361199}

Patch Set 1 #

Patch Set 2 : Use regular raw ptr. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -55 lines) Patch
M third_party/WebKit/Source/core/svg/SVGPathParser.h View 1 1 chunk +22 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGPathParser.cpp View 6 chunks +34 lines, -55 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
fs
I compared the generated code for SVGPathNormalizer/NormalizingConsumer::emitSegment (the same size!) and did not see any ...
5 years, 1 month ago (2015-11-23 18:54:57 UTC) #2
pdr.
LGTM Curious.. is there a path towards removing the normalized path concept?
5 years, 1 month ago (2015-11-23 18:58:09 UTC) #3
fs
On 2015/11/23 at 18:58:09, pdr wrote: > LGTM > > Curious.. is there a path ...
5 years, 1 month ago (2015-11-23 19:32:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472853005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472853005/20001
5 years, 1 month ago (2015-11-23 20:09:43 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-11-23 22:13:00 UTC) #7
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 22:14:00 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7b2566560022cdec110c2ec09068723ccc969a16
Cr-Commit-Position: refs/heads/master@{#361199}

Powered by Google App Engine
This is Rietveld 408576698