Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1472833006: Subzero: Add "szbuild_spec2k.py --run" option. (Closed)

Created:
5 years ago by Jim Stichnoth
Modified:
5 years ago
Reviewers:
Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Add "szbuild_spec2k.py --run" option. This makes it easier to do bisection debugging. Note that this could be used to simplify "make -f Makefile.standalone check-spec", but I chose not to do that because shellcmd() buffers all of the stdout until completion, which is not a great user experience (at least for this user). BUG= none R=sehr@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=83f957a1e23ac83ccb086d7d67dd71b7193943ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M pydir/szbuild_spec2k.py View 3 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
5 years ago (2015-11-25 17:55:26 UTC) #3
sehr
lgtm
5 years ago (2015-11-25 20:24:11 UTC) #4
Jim Stichnoth
5 years ago (2015-11-25 23:19:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
83f957a1e23ac83ccb086d7d67dd71b7193943ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698