Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1472823004: PPC: Reshuffle registers in JSConstructStub to avoid trashing costructor and new.target on fast pat… (Closed)

Created:
5 years ago by MTBrandyberry
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Reshuffle registers in JSConstructStub to avoid trashing costructor and new.target on fast path (so we don't need to push/pop them). Port 0ef5ad5ab97657f7e3393be7512fef883b205c87 Original commit message: This CL also fixed register usages in MacroAssembler::Allocate() broken by 2fc2cb99 (r32144). R=ishell@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:560239 LOG=Y Committed: https://crrev.com/9b3dff93ad8ddf616298bf7be4a37450728158b2 Cr-Commit-Position: refs/heads/master@{#32230}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -83 lines) Patch
M src/ppc/builtins-ppc.cc View 5 chunks +33 lines, -28 lines 0 comments Download
M src/ppc/code-stubs-ppc.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 9 chunks +43 lines, -52 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
MTBrandyberry
5 years ago (2015-11-24 19:16:16 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472823004/1
5 years ago (2015-11-24 20:00:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-24 20:58:41 UTC) #5
michael_dawson
On 2015/11/24 20:58:41, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-11-24 21:14:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472823004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472823004/1
5 years ago (2015-11-24 21:25:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-24 21:27:39 UTC) #9
commit-bot: I haz the power
5 years ago (2015-11-24 21:27:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b3dff93ad8ddf616298bf7be4a37450728158b2
Cr-Commit-Position: refs/heads/master@{#32230}

Powered by Google App Engine
This is Rietveld 408576698