Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 1472773002: Split filter related measurements from SVG1DOM counter (Closed)

Created:
5 years, 1 month ago by davve
Modified:
5 years, 1 month ago
CC:
fs, asvitkine+watch_chromium.org, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split filter related measurements from SVG1DOM counter Create a SVG1DOMFilter UseCounter to measure all filter related SVG DOM functionality. The assumption we want to test is that the filter related SVG DOM has really low usage. From a quick test it would shave off 90kb of the binary if we could remove it. That's only counting binding code and there is a good chance number-optional-number related functionality can be removed too, if these interfaces can be removed. BUG=415074 Committed: https://crrev.com/f4deb4a41565ae3de05854aac122b9970a82526d Cr-Commit-Position: refs/heads/master@{#361181}

Patch Set 1 #

Patch Set 2 : Rename counter to SVG1DOMFilter #

Patch Set 3 : Fix histograms.xml #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -140 lines) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGComponentTransferFunctionElement.idl View 1 1 chunk +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEBlendElement.idl View 1 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEColorMatrixElement.idl View 1 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEComponentTransferElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFECompositeElement.idl View 1 1 chunk +14 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEConvolveMatrixElement.idl View 1 1 chunk +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDiffuseLightingElement.idl View 1 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDisplacementMapElement.idl View 1 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDistantLightElement.idl View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEDropShadowElement.idl View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEGaussianBlurElement.idl View 1 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEImageElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMergeNodeElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEMorphologyElement.idl View 1 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEOffsetElement.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFEPointLightElement.idl View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpecularLightingElement.idl View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFESpotLightElement.idl View 1 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETileElement.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFETurbulenceElement.idl View 1 1 chunk +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterElement.idl View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGFilterPrimitiveStandardAttributes.idl View 1 1 chunk +5 lines, -5 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
davve
One stab at the SVG1DOM counter. PTAL.
5 years, 1 month ago (2015-11-23 13:46:36 UTC) #5
fs
lgtm
5 years, 1 month ago (2015-11-23 14:06:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472773002/40001
5 years, 1 month ago (2015-11-23 14:13:36 UTC) #8
davve
+isherman for metrics
5 years, 1 month ago (2015-11-23 14:17:41 UTC) #11
Ilya Sherman
histograms.xml lgtm
5 years, 1 month ago (2015-11-23 19:23:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472773002/40001
5 years, 1 month ago (2015-11-23 20:22:05 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-23 20:44:22 UTC) #15
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 20:45:23 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f4deb4a41565ae3de05854aac122b9970a82526d
Cr-Commit-Position: refs/heads/master@{#361181}

Powered by Google App Engine
This is Rietveld 408576698