Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1472763002: Workaround dependency on closure library in chromevox test utility. (Closed)

Created:
5 years, 1 month ago by Peter Lundblad
Modified:
5 years, 1 month ago
Reviewers:
aboxhall
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Workaround dependency on closure library in chromevox test utility. This used to work because the accessibility audit library pulls in parts of the closure libray. Since it doesn't leak its internals in a newer version, this dependency problem was exposed. The underlying issue is that GEN_INCLUDES in the js test are included before closureModuleDeps, so declarations from the latter are not available when evaluating the former. Needed for https://codereview.chromium.org/1447693002/ BUG=555753 R=aboxhall@chromium.org Committed: https://crrev.com/7c2d5428accfe76853d8001158883c4814fa6ae2 Cr-Commit-Position: refs/heads/master@{#361142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/browser/resources/chromeos/chromevox/walkers/walker_unittest_base.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Peter Lundblad
5 years, 1 month ago (2015-11-23 12:03:49 UTC) #1
aboxhall
lgtm
5 years, 1 month ago (2015-11-23 17:50:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472763002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472763002/1
5 years, 1 month ago (2015-11-23 17:51:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 18:16:21 UTC) #5
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 18:17:23 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c2d5428accfe76853d8001158883c4814fa6ae2
Cr-Commit-Position: refs/heads/master@{#361142}

Powered by Google App Engine
This is Rietveld 408576698