Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Issue 1472753003: Revert of Makes window manager include ui pak file (Closed)

Created:
5 years, 1 month ago by sky
Modified:
5 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, rjkroege, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Makes window manager include ui pak file (patchset #1 id:1 of https://codereview.chromium.org/1466483003/ ) Reason for revert: I'm reverting this and will instead include it in the wm. Original issue's description: > Makes window manager include ui pak file > > We'll need this for cursors and shadows. > > BUG=548426 > TEST=none > R=erg@chromium.org > > Committed: https://crrev.com/35b0cd220fd2a788c16055b756e8483936b0e384 > Cr-Commit-Position: refs/heads/master@{#361162} TBR=erg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=548426 Committed: https://crrev.com/70c88376cec2c19eb322aa221bcc45e491fa580e Cr-Commit-Position: refs/heads/master@{#361225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -37 lines) Patch
M components/mus/BUILD.gn View 3 chunks +1 line, -10 lines 0 comments Download
M components/mus/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/mus/mus_app.cc View 4 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
Created Revert of Makes window manager include ui pak file
5 years, 1 month ago (2015-11-24 00:11:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472753003/1
5 years, 1 month ago (2015-11-24 00:14:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-24 00:17:37 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-24 00:19:08 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70c88376cec2c19eb322aa221bcc45e491fa580e
Cr-Commit-Position: refs/heads/master@{#361225}

Powered by Google App Engine
This is Rietveld 408576698