Issue 1472743002: Revert of Re-enable HTTP/2 over NPN (for OpenSSL).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1472743002: Revert of Re-enable HTTP/2 over NPN (for OpenSSL). (Closed)

Created:
5 years, 1 month ago by Alexander Potapenko

Modified:
5 years, 1 month ago

Reviewers:
cbentzel, Bence

CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Re-enable HTTP/2 over NPN (for OpenSSL). (patchset #3 id:40001 of https://codereview.chromium.org/1453903002/ ) Reason for revert: The CL has introduced massive MSan and Valgrind reports, see the bug. BUG=557197 Original issue's description: > Re-enable HTTP/2 over NPN (for OpenSSL). > > BUG=557197 > > Committed: https://crrev.com/0eb771aa98ba2bd4db0e2b82241afe8f5760c32e > Cr-Commit-Position: refs/heads/master@{#361053} TBR=cbentzel@chromium.org,bnc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=557197 Committed: https://crrev.com/e038f1dc42693ffe6fc47c719a9051b9e0a05651 Cr-Commit-Position: refs/heads/master@{#361088}

Patch Set 1 #

Created: 5 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -31 lines)			Patch
M	net/http/http_network_session.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	net/http/http_network_transaction.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	net/http/http_network_transaction_unittest.cc	View	2 chunks	+0 lines, -26 lines	0 comments	Download
M	net/spdy/spdy_test_util_common.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/spdy/spdy_test_util_common.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Alexander Potapenko

Created Revert of Re-enable HTTP/2 over NPN (for OpenSSL).

5 years, 1 month ago (2015-11-23 11:28:13 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472743002/1

5 years, 1 month ago (2015-11-23 11:28:31 UTC) #2

commit-bot: I haz the power

5 years, 1 month ago (2015-11-23 11:29:51 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/e038f1dc42693ffe6fc47c719a9051b9e0a05651
Cr-Commit-Position: refs/heads/master@{#361088}

Expand Messages | Collapse Messages