Include conic weights in GrPath cache kSimpleVolatilePathDomain keys

Include conic weights in GrPath cache kSimpleVolatilePathDomain keys

Include conic weights in the keys when caching GrPath in
kSimpleVolatilePathDomain.

BUG=skia:4580
Committed: https://skia.googlesource.com/skia/+/f15246320cf69cd7bcd8882601c67eddc655d9ba

[Kimmo Kinnunen, 2015-11-23 09:27:58]

kkinnunen@nvidia.com changed reviewers:
+ fmalita@chromium.org, reed@google.com

[Kimmo Kinnunen, 2015-11-23 09:27:58]

reed@ for public SkPath API change

[Kimmo Kinnunen, 2015-11-24 11:04:39]

kkinnunen@nvidia.com changed reviewers:
+ bsalomon@google.com

[Kimmo Kinnunen, 2015-11-24 11:04:39]

.. I seem to recall now Mike rejecting the conic weights accessor in SkPath API.
Fixed the patch to not require it.

[f(malita), 2015-11-24 13:49:11]

On 2015/11/24 11:04:39, Kimmo Kinnunen wrote:
> .. I seem to recall now Mike rejecting the conic weights accessor in SkPath
API.
> Fixed the patch to not require it.

I would prefer to avoid iterating over verbs, but up to Mike.  Another way to
avoid pub API changes would be to befriend GrPath -> SkPath and access the
SkPathRef directly.

Impl LGTM.

[reed1, 2015-11-24 15:23:17]

I'm fine making GrPath a friend, so it can peer into SkPathRef directly.

[Kimmo Kinnunen, 2015-11-24 15:47:49]

On 2015/11/24 15:23:17, reed1 wrote:
> I'm fine making GrPath a friend, so it can peer into SkPathRef directly.

Same pattern is in GrGLPath, too.

Is it ok if we merge this patch and I do the friend modification in a separate
patch?

[f(malita), 2015-11-24 15:56:02]

On 2015/11/24 15:47:49, Kimmo Kinnunen wrote:
> On 2015/11/24 15:23:17, reed1 wrote:
> > I'm fine making GrPath a friend, so it can peer into SkPathRef directly.
> 
> Same pattern is in GrGLPath, too.
> 
> Is it ok if we merge this patch and I do the friend modification in a separate
> patch?

SGTM

[Kimmo Kinnunen, 2015-11-24 16:01:55]

The CQ bit was checked by kkinnunen@nvidia.com

[commit-bot: I haz the power, 2015-11-24 16:01:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-24 16:01:59]

This CL has an open dependency (Issue 1448873002 Patch 40001). Please resolve
the dependency and try again.

[Kimmo Kinnunen, 2015-11-25 05:06:02]

Description was changed from

==========
Include conic weights in GrPath cache kSimpleVolatilePathDomain keys

Include conic weights in the keys when caching GrPath in
kSimpleVolatilePathDomain.

Adds following methods to the public API:
int SkPath::countConicWeights() const;
int SkPath::getConicWeights(SkScalar conicWeights[], int max) const;

BUG=skia:4580
==========

to

==========
Include conic weights in GrPath cache kSimpleVolatilePathDomain keys

Include conic weights in the keys when caching GrPath in
kSimpleVolatilePathDomain.

BUG=skia:4580
==========

[Kimmo Kinnunen, 2015-11-26 09:38:46]

The CQ bit was checked by kkinnunen@nvidia.com

[Kimmo Kinnunen, 2015-11-26 09:38:46]

The patchset sent to the CQ was uploaded after l-g-t-m from fmalita@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1472733002/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-11-26 09:38:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1472733002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1472733002/80001

[commit-bot: I haz the power, 2015-11-26 09:51:47]

Description was changed from

==========
Include conic weights in GrPath cache kSimpleVolatilePathDomain keys

Include conic weights in the keys when caching GrPath in
kSimpleVolatilePathDomain.

BUG=skia:4580
==========

to

==========
Include conic weights in GrPath cache kSimpleVolatilePathDomain keys

Include conic weights in the keys when caching GrPath in
kSimpleVolatilePathDomain.

BUG=skia:4580

Committed:
https://skia.googlesource.com/skia/+/f15246320cf69cd7bcd8882601c67eddc655d9ba
==========

[commit-bot: I haz the power, 2015-11-26 09:51:48]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/f15246320cf69cd7bcd8882601c67eddc655d9ba