Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 147273005: Allow Google Now on all Desktop OS Platforms (Closed)

Created:
6 years, 10 months ago by robliao
Modified:
6 years, 10 months ago
Reviewers:
vadimt, rgustafson, skare_
CC:
chromium-reviews
Visibility:
Public.

Description

Allow Google Now on all Desktop OS Platforms With the addition of Linux support for rich notifications, we can turn on Google Now for all desktop platforms. BUG=164227 R=skare@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248609

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/about_flags.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
robliao
6 years, 10 months ago (2014-02-03 22:16:02 UTC) #1
skare_
lgtm yay linux
6 years, 10 months ago (2014-02-03 23:04:54 UTC) #2
rgustafson
Linux users who turn this flag on without enabling aura/rich notifications are going to get ...
6 years, 10 months ago (2014-02-03 23:08:32 UTC) #3
robliao
On 2014/02/03 23:08:32, rgustafson wrote: > Linux users who turn this flag on without enabling ...
6 years, 10 months ago (2014-02-03 23:22:18 UTC) #4
robliao
Committed patchset #1 manually as r248609 (presubmit successful).
6 years, 10 months ago (2014-02-03 23:27:44 UTC) #5
rgustafson
lgtm Considering the case of Linux Aura being rolled back in favor of non-Aura but ...
6 years, 10 months ago (2014-02-03 23:28:35 UTC) #6
vadimt
6 years, 10 months ago (2014-02-04 18:44:17 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698