Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1472703006: Move and rename host/cast_video_capture_adapter to protocol/webrtc_video_capture_adapter (Closed)

Created:
5 years, 1 month ago by Sergey Ulanov
Modified:
5 years ago
Reviewers:
Jamie
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move and rename host/cast_video_capture_adapter to protocol/webrtc_video_capture_adapter The adapter will be used in the protocol layer for WebRTC-based connections. BUG=547158 Committed: https://crrev.com/2536ddbba72ac599fe2bcedf2b9c29cb0d292dc9 Cr-Commit-Position: refs/heads/master@{#361465}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -315 lines) Patch
M remoting/host/cast_extension_session.cc View 3 chunks +4 lines, -4 lines 0 comments Download
D remoting/host/cast_video_capturer_adapter.h View 1 chunk +0 lines, -79 lines 0 comments Download
D remoting/host/cast_video_capturer_adapter.cc View 1 chunk +0 lines, -195 lines 0 comments Download
M remoting/protocol/BUILD.gn View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download
A + remoting/protocol/webrtc_video_capturer_adapter.h View 1 2 4 chunks +11 lines, -11 lines 0 comments Download
A + remoting/protocol/webrtc_video_capturer_adapter.cc View 1 2 13 chunks +23 lines, -23 lines 0 comments Download
M remoting/remoting_host_srcs.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/remoting_srcs.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Sergey Ulanov
5 years, 1 month ago (2015-11-23 23:32:36 UTC) #2
Jamie
https://codereview.chromium.org/1472703006/diff/20001/remoting/remoting_srcs.gypi File remoting/remoting_srcs.gypi (right): https://codereview.chromium.org/1472703006/diff/20001/remoting/remoting_srcs.gypi#newcode222 remoting/remoting_srcs.gypi:222: 'protocol/webrtc_video_capturer_adapter.h', I don't see these files in this CL.
5 years, 1 month ago (2015-11-24 00:21:42 UTC) #3
Sergey Ulanov
https://codereview.chromium.org/1472703006/diff/20001/remoting/remoting_srcs.gypi File remoting/remoting_srcs.gypi (right): https://codereview.chromium.org/1472703006/diff/20001/remoting/remoting_srcs.gypi#newcode222 remoting/remoting_srcs.gypi:222: 'protocol/webrtc_video_capturer_adapter.h', On 2015/11/24 00:21:42, Jamie wrote: > I don't ...
5 years, 1 month ago (2015-11-24 01:17:06 UTC) #4
Jamie
lgtm
5 years, 1 month ago (2015-11-24 01:25:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472703006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472703006/40001
5 years ago (2015-11-24 16:17:49 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/34258)
5 years ago (2015-11-24 17:17:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472703006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472703006/60001
5 years ago (2015-11-24 20:19:00 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-11-24 22:08:00 UTC) #13
commit-bot: I haz the power
5 years ago (2015-11-24 22:08:55 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/2536ddbba72ac599fe2bcedf2b9c29cb0d292dc9
Cr-Commit-Position: refs/heads/master@{#361465}

Powered by Google App Engine
This is Rietveld 408576698