Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1472703005: [turbofan] Teach ad-hoc load elimination about atomic regions. (Closed)

Created:
5 years, 1 month ago by Benedikt Meurer
Modified:
5 years, 1 month ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Teach ad-hoc load elimination about atomic regions. The LoadElimination in TurboFan can look into the atomic regions and elimination subsequent loads based on stores/allocations in that atomic regions. R=jarin@chromium.org Committed: https://crrev.com/902f264a5725b3563a6a4aca3cea9dc59db0d92d Cr-Commit-Position: refs/heads/master@{#32179}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/compiler/load-elimination.cc View 2 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 1 month ago (2015-11-23 14:08:41 UTC) #1
Benedikt Meurer
Hey Jaro, We talked about this earlier, that the load elimination should be able to ...
5 years, 1 month ago (2015-11-23 14:10:00 UTC) #2
Jarin
lgtm
5 years, 1 month ago (2015-11-23 14:13:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472703005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472703005/1
5 years, 1 month ago (2015-11-23 14:32:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 14:43:36 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 14:44:03 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/902f264a5725b3563a6a4aca3cea9dc59db0d92d
Cr-Commit-Position: refs/heads/master@{#32179}

Powered by Google App Engine
This is Rietveld 408576698