Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1945)

Unified Diff: content/browser/frame_host/render_frame_host_manager_browsertest.cc

Issue 1472703004: Reland #2 of: Move WebUI ownership from the RenderFrameHostManager to the RenderFrameHost. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Test shared code now uses lambda functions. More comments. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_manager_browsertest.cc
diff --git a/content/browser/frame_host/render_frame_host_manager_browsertest.cc b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
index af01878df6a79eb4ff08918d3cce0ffe380b0153..cba8284d24803694c7a4b494b6f9ab7f54e83640 100644
--- a/content/browser/frame_host/render_frame_host_manager_browsertest.cc
+++ b/content/browser/frame_host/render_frame_host_manager_browsertest.cc
@@ -1740,16 +1740,19 @@ IN_PROC_BROWSER_TEST_F(RenderFrameHostManagerTest,
shell()->web_contents()->GetRenderProcessHost()->GetID()));
WebContentsImpl* web_contents = static_cast<WebContentsImpl*>(
shell()->web_contents());
- WebUIImpl* webui = web_contents->GetRenderManagerForTesting()->web_ui();
+ FrameTreeNode* root = web_contents->GetFrameTree()->root();
+ WebUIImpl* webui = root->current_frame_host()->web_ui();
EXPECT_TRUE(webui);
- EXPECT_FALSE(web_contents->GetRenderManagerForTesting()->pending_web_ui());
+ EXPECT_FALSE(
+ web_contents->GetRenderManagerForTesting()->GetNavigatingWebUI());
- // Navigate to another WebUI URL that reuses the WebUI object. Make sure we
- // clear pending_web_ui() when it commits.
+ // Navigate to another WebUI URL that reuses the WebUI object. Make sure we
+ // clear GetNavigatingWebUI() when it commits.
GURL webui_url2(webui_url.spec() + "#foo");
NavigateToURL(shell(), webui_url2);
- EXPECT_EQ(webui, web_contents->GetRenderManagerForTesting()->web_ui());
- EXPECT_FALSE(web_contents->GetRenderManagerForTesting()->pending_web_ui());
+ EXPECT_EQ(webui, root->current_frame_host()->web_ui());
+ EXPECT_FALSE(
+ web_contents->GetRenderManagerForTesting()->GetNavigatingWebUI());
}
class RFHMProcessPerTabTest : public RenderFrameHostManagerTest {

Powered by Google App Engine
This is Rietveld 408576698