Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1472703002: X87: [turbofan]: Implement tail calls with more callee than caller parameters. (Closed)

Created:
5 years, 1 month ago by zhengxing.li
Modified:
5 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan]: Implement tail calls with more callee than caller parameters. port c6d310da4d86ce2d8178a49f4d34b66ad6143432 (r32151) original commit message: * Adds a PrepareForTailCall instruction that bumps the stack in the case that the number of parameters passed to the callee causes the stack to exceed the calleer's frame size. * Uses the gap resolver to move the saved caller return address and frame pointer to the approprate location in the tail-called frame. BUG= Committed: https://crrev.com/8dda6ee726674ab216e0e264c28e3fe9b9d62f0c Cr-Commit-Position: refs/heads/master@{#32162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +17 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
zhengxing.li
5 years, 1 month ago (2015-11-23 02:28:22 UTC) #2
Weiliang
lgtm
5 years, 1 month ago (2015-11-23 02:58:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472703002/1
5 years, 1 month ago (2015-11-23 02:58:29 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 03:30:35 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-23 03:30:48 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8dda6ee726674ab216e0e264c28e3fe9b9d62f0c
Cr-Commit-Position: refs/heads/master@{#32162}

Powered by Google App Engine
This is Rietveld 408576698