components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java - Issue 1472693003: [Cronet] Clear mock cert verifier reference in CronetEngine.Builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

Issue 1472693003: [Cronet] Clear mock cert verifier reference in CronetEngine.Builder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Misha's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/QuicTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

index 0e758e70cbdc9889ae30c2d6212ecd939d475681..9defc4ac4de3f5cdacbace32cb6e28828114f24d 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/HttpUrlRequestFactoryTest.java

@@ -29,8 +29,10 @@ public class HttpUrlRequestFactoryTest extends CronetTestBase {

builder.addQuicHint("www.google.com", 443, 443);

builder.addQuicHint("www.youtube.com", 443, 443);

builder.setLibraryName("cronet_tests");

+ String[] commandLineArgs = {

+ CronetTestFramework.LIBRARY_INIT_KEY, CronetTestFramework.LibraryInitType.LEGACY};

CronetTestFramework testFramework =

- startCronetTestFrameworkWithUrlAndCronetEngineBuilder(URL, builder);

+ new CronetTestFramework(URL, commandLineArgs, getContext(), builder);

HttpUrlRequestFactory factory = testFramework.mRequestFactory;

assertNotNull("Factory should be created", factory);

assertTrue("Factory should be Chromium/n.n.n.n@r but is "