Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 1472693003: [Cronet] Clear mock cert verifier reference in CronetEngine.Builder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Misha's comments Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java
diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
index 5047ab6e23f289342e02621113f98ffaaf7afa9d..6e7d1e0940ccc2fa4668cc24373cd866e90866ea 100644
--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java
@@ -382,7 +382,11 @@ public abstract class CronetEngine {
* Build a {@link CronetEngine} using this builder's configuration.
*/
public CronetEngine build() {
- return createContext(this);
+ CronetEngine engine = createContext(this);
+ // Clear MOCK_CERT_VERIFIER reference if there is any, since
+ // the ownership has been transferred to the engine.
+ mConfig.remove(CronetEngineBuilderList.MOCK_CERT_VERIFIER);
+ return engine;
}
}
« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698