components/cronet/android/test/javatests/src/org/chromium/net/UploadTest.java - Issue 1472693003: [Cronet] Clear mock cert verifier reference in CronetEngine.Builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/UploadTest.java

Issue 1472693003: [Cronet] Clear mock cert verifier reference in CronetEngine.Builder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java ('K') | « components/cronet/android/test/javatests/src/org/chromium/net/SdchTest.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetBufferedOutputStreamTest.java » ('j') | components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/UploadTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/UploadTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/UploadTest.java

index 7265094dcfbfb13cb4ff3bc426fcbcf1243daff2..f7ea7ca90761d4b4ddea76943f63cd66708c1472 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/UploadTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/UploadTest.java

@@ -30,7 +30,9 @@ public class UploadTest extends CronetTestBase {

// @Override

protected void setUp() throws Exception {

super.setUp();

- mTestFramework = startCronetTestFramework();

+ String[] commandLineArgs = new String[] {

mef 2015/11/24 20:38:33 not used?

xunjieli 2015/11/24 21:28:06 Done.

+ CronetTestFramework.LIBRARY_INIT_KEY, CronetTestFramework.LibraryInitType.LEGACY};

+ mTestFramework = new CronetTestFramework(null, mTestFramework, getContext(), null);

mef 2015/11/24 20:38:33 wrong copy-paste?

xunjieli 2015/11/24 21:28:06 Done. Thanks! I wonder how the tests managed to pa

assertNotNull(mTestFramework);

assertTrue(NativeTestServer.startNativeTestServer(getContext()));

}