components/cronet/android/api/src/org/chromium/net/CronetEngine.java - Issue 1472693003: [Cronet] Clear mock cert verifier reference in CronetEngine.Builder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

Issue 1472693003: [Cronet] Clear mock cert verifier reference in CronetEngine.Builder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | components/cronet/android/test/javatests/src/org/chromium/net/ChromiumUrlRequestTest.java » ('j') | components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/api/src/org/chromium/net/CronetEngine.java

diff --git a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java

index 5047ab6e23f289342e02621113f98ffaaf7afa9d..6e7d1e0940ccc2fa4668cc24373cd866e90866ea 100644

--- a/components/cronet/android/api/src/org/chromium/net/CronetEngine.java

+++ b/components/cronet/android/api/src/org/chromium/net/CronetEngine.java

@@ -382,7 +382,11 @@ public abstract class CronetEngine {

* Build a {@link CronetEngine} using this builder's configuration.

public CronetEngine build() {

- return createContext(this);

+ CronetEngine engine = createContext(this);

+ // Clear MOCK_CERT_VERIFIER reference if there is any, since

+ // the ownership has been transferred to the engine.

+ mConfig.remove(CronetEngineBuilderList.MOCK_CERT_VERIFIER);

+ return engine;

}