Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 1472693002: Revert of components/metrics: Add runtime memory leak detector (Closed)

Created:
5 years, 1 month ago by tsergeant
Modified:
5 years, 1 month ago
CC:
bccheng, bjanakiraman1, chromium-reviews, darin-cc_chromium.org, dhsharp, Dai Mikurube (NOT FULLTIME), erikwright+watch_chromium.org, gpike, jam, jar (doing other things), kouhei (in TOK), rapati, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of components/metrics: Add runtime memory leak detector (patchset #52 id:2120001 of https://codereview.chromium.org/986503002/ ) Reason for revert: This CL has been causing the builder Linux ChromiumOS Tests (dbg)(1) to fail: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/9298 Original issue's description: > components/metrics: Add runtime memory leak detector > > This patch adds heuristic-based memory leak detector. > Unlike traditional leak detectors like valgrind, > it doesn't wait until a process terminates to check for > leftover allocations. Instead, it analyzes allocation > patterns over time. > > This code is not thread-safe. It is up to the caller of this code to ensure thread safety. > > BUG=382705 > > Signed-off-by: Simon Que <sque@chromium.org>; > > Committed: https://crrev.com/d02b109cb1f41b7ea0584d0910c8bb4cf21cb521 > Cr-Commit-Position: refs/heads/master@{#361012} TBR=jochen@chromium.org,asvitkine@chromium.org,bjanakiraman@chromium.org,gpike@chromium.org,jar@chromium.org,thakis@chromium.org,wfh@chromium.org,sque@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=382705 Committed: https://crrev.com/0ce07d8542c286510f4ea85c89da3ee070fe4b4a Cr-Commit-Position: refs/heads/master@{#361058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3055 lines) Patch
M components/components_tests.gyp View 3 chunks +0 lines, -9 lines 0 comments Download
M components/metrics.gypi View 1 chunk +0 lines, -23 lines 0 comments Download
M components/metrics/BUILD.gn View 3 chunks +0 lines, -44 lines 0 comments Download
D components/metrics/leak_detector/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D components/metrics/leak_detector/call_stack_manager.h View 1 chunk +0 lines, -100 lines 0 comments Download
D components/metrics/leak_detector/call_stack_manager.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D components/metrics/leak_detector/call_stack_manager_unittest.cc View 1 chunk +0 lines, -260 lines 0 comments Download
D components/metrics/leak_detector/call_stack_table.h View 1 chunk +0 lines, -81 lines 0 comments Download
D components/metrics/leak_detector/call_stack_table.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D components/metrics/leak_detector/call_stack_table_unittest.cc View 1 chunk +0 lines, -306 lines 0 comments Download
D components/metrics/leak_detector/custom_allocator.h View 1 chunk +0 lines, -50 lines 0 comments Download
D components/metrics/leak_detector/custom_allocator.cc View 1 chunk +0 lines, -61 lines 0 comments Download
D components/metrics/leak_detector/leak_analyzer.h View 1 chunk +0 lines, -81 lines 0 comments Download
D components/metrics/leak_detector/leak_analyzer.cc View 1 chunk +0 lines, -139 lines 0 comments Download
D components/metrics/leak_detector/leak_analyzer_unittest.cc View 1 chunk +0 lines, -362 lines 0 comments Download
D components/metrics/leak_detector/leak_detector_impl.h View 1 chunk +0 lines, -161 lines 0 comments Download
D components/metrics/leak_detector/leak_detector_impl.cc View 1 chunk +0 lines, -215 lines 0 comments Download
D components/metrics/leak_detector/leak_detector_impl_unittest.cc View 1 chunk +0 lines, -464 lines 0 comments Download
D components/metrics/leak_detector/leak_detector_value_type.h View 1 chunk +0 lines, -52 lines 0 comments Download
D components/metrics/leak_detector/leak_detector_value_type.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D components/metrics/leak_detector/ranked_list.h View 1 chunk +0 lines, -81 lines 0 comments Download
D components/metrics/leak_detector/ranked_list.cc View 1 chunk +0 lines, -45 lines 0 comments Download
D components/metrics/leak_detector/ranked_list_unittest.cc View 1 chunk +0 lines, -266 lines 0 comments Download
D components/metrics/leak_detector/stl_allocator.h View 1 chunk +0 lines, -61 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tsergeant
Created Revert of components/metrics: Add runtime memory leak detector
5 years, 1 month ago (2015-11-23 00:06:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472693002/1
5 years, 1 month ago (2015-11-23 00:07:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-23 00:07:54 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0ce07d8542c286510f4ea85c89da3ee070fe4b4a Cr-Commit-Position: refs/heads/master@{#361058}
5 years, 1 month ago (2015-11-23 00:08:57 UTC) #4
Simon Que
5 years, 1 month ago (2015-11-23 00:26:22 UTC) #5
Message was sent while issue was closed.
On 2015/11/23 00:08:57, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/0ce07d8542c286510f4ea85c89da3ee070fe4b4a
> Cr-Commit-Position: refs/heads/master@{#361058}

I created CLs to fix it, and linked to them on the appropriate threads. I guess
you missed them.
https://codereview.chromium.org/1468873002/
https://codereview.chromium.org/1471623003/

Powered by Google App Engine
This is Rietveld 408576698