Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1472673002: WebContentsViewAura: Remove redundant if statement (Closed)

Created:
5 years, 1 month ago by Fady Samuel
Modified:
5 years, 1 month ago
Reviewers:
sadrul
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebContentsViewAura: Remove redundant if statement BUG=none Committed: https://crrev.com/562d9e4109940c428c1716cc1efedd03b7598500 Cr-Commit-Position: refs/heads/master@{#361048}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
+sadrul@: looks like you're OWNER here. Please review? This is trivial, we have two if ...
5 years, 1 month ago (2015-11-22 17:48:03 UTC) #2
sadrul
I don't know ... maybe it's good to be really really sure? lgtm
5 years, 1 month ago (2015-11-22 17:51:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1472673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1472673002/1
5 years, 1 month ago (2015-11-22 17:52:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-22 20:20:29 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-22 20:30:15 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/562d9e4109940c428c1716cc1efedd03b7598500
Cr-Commit-Position: refs/heads/master@{#361048}

Powered by Google App Engine
This is Rietveld 408576698