tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll - Issue 1472623002: Unify alloca, outgoing arg, and prolog construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll

Issue 1472623002: Unify alloca, outgoing arg, and prolog construction (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Code review fixes. Also removed StackAdjustment. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll

diff --git a/tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll b/tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll

index aea34ade3a7a7cc86a28fe9ee0d0288b36234d5c..433bd0a8803a59b7f91e9fa0a8b5452cb25242d6 100644

--- a/tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll

+++ b/tests_lit/llvm2ice_tests/nacl-other-intrinsics.ll

@@ -540,11 +540,15 @@ entry:

ret void

}

; CHECK-LABEL: test_stacksave_multiple

-; At least 3 copies of esp, but probably more from having to do the allocas.

-; CHECK: mov {{.*}},esp

+; lea is used to copy from esp for the allocas.

+; Otherwise, only one stacksave is live.

+; CHECK: mov ebp,esp

; CHECK: mov {{.*}},esp

+; CHECK: lea {{.*}},[esp+0x10]

+; CHECK: call

; CHECK: mov esp,{{.*}}

+; CHECK: mov esp,ebp

; ARM32-LABEL: test_stacksave_multiple

; ARM32: mov {{.*}}, sp

« no previous file with comments | « tests_lit/llvm2ice_tests/int-arg.ll ('k') | tests_lit/llvm2ice_tests/vector-arg.ll » ('j') | no next file with comments »